Casting float to integer in LitterBox translation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request!
You are right here - you propose to use integer even if the Furthermore, casting floats to ints cuts off the decimal places instead of rounding. That results in unneccessary imprecision and we suggest to use In the long term we also consider to allow floats for the "change x by" and "change y by" blocks, as rounding floats in general discards relevant information, so why not keep it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve a bug that - when translating a Scratch program that has floating points in "change x by", "change y by", it gives an error:
Exception in thread "main" java.lang.RuntimeException: Expected type integer but got 5.5, we have casted all float literals to int unless expectFloat is explicit.However, this may have caused us to cast some that are not supposed to be integers to integers. So please let us know if there are other ways to change the translation method.